Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for wildcard prefix in DNS internet intents (*.example.com) #256

Merged
merged 4 commits into from
Dec 15, 2024
Merged

Adding support for wildcard prefix in DNS internet intents (*.example.com) #256

merged 4 commits into from
Dec 15, 2024

Conversation

evyatarmeged
Copy link
Contributor

Description

Adding support for wildcard prefix in DNS internet intents (*.example.com)### References

  • This change adds test coverage for new/changed/fixed functionality

amitlicht
amitlicht requested changes Dec 11, 2024
View reviewed changes
src/mapper/pkg/dnscache/dns_cache.go Outdated Show resolved Hide resolved
src/mapper/pkg/dnscache/dns_cache.go Show resolved Hide resolved
src/mapper/pkg/dnsintentspublisher/dns_intents_publisher.go Outdated Show resolved Hide resolved
src/mapper/pkg/dnsintentspublisher/dns_intents_publisher.go Outdated Show resolved Hide resolved
src/mapper/pkg/dnsintentspublisher/dns_intents_publisher.go Outdated Show resolved Hide resolved
src/mapper/pkg/resolvers/schema.helpers.resolvers.go Outdated Show resolved Hide resolved
amitlicht
amitlicht requested changes Dec 15, 2024
View reviewed changes
src/mapper/pkg/dnsintentspublisher/dns_intents_publisher.go Outdated Show resolved Hide resolved
src/mapper/pkg/dnscache/dns_cache.go Outdated Show resolved Hide resolved
@evyatarmeged evyatarmeged merged commit 31229a3 into main Dec 15, 2024
21 checks passed
@evyatarmeged evyatarmeged deleted the evya/support_wildcard_dns_intents branch December 15, 2024 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@amitlicht amitlicht amitlicht approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evyatarmeged @amitlicht