Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pci-private-network): Configure private network and subnet in same page #13795

Open
wants to merge 3 commits into
base: feat/private-network-refactor1
Choose a base branch
from
Open

feat(pci-private-network): Configure private network and subnet in same page #13795

wants to merge 3 commits into from
+216 −147

Conversation

Tsiorifamonjena
Copy link
Contributor

@Tsiorifamonjena Tsiorifamonjena commented Oct 25, 2024 •
edited
Loading

ref: TAPC-1824

Question Answer
Branch? feat/private-network-refactor1
Bug fix? no
New feature? yes
Breaking change? no
Tickets Fix #TAPC-1824
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@Tsiorifamonjena Tsiorifamonjena requested review from a team as code owners October 25, 2024 13:05
@Tsiorifamonjena Tsiorifamonjena requested review from frenautvh, seven-amid, tibs245, MaximeBajeux and darsene and removed request for a team October 25, 2024 13:05
@github-actions github-actions bot added dependencies Pull requests that update a dependency file universe-public-cloud feature New feature has conflicts Has conflicts to resolve before merging labels Oct 25, 2024
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-private-network_subnet_tapc-1824 branch from ca37b44 to 033936c Compare October 25, 2024 13:15
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
@babel/runtime UPDATED 7.22.15 7.25.7
@hookform/resolvers UPDATED 3.3.4 3.9.0
@types/react UPDATED 18.2.55 18.3.11
graphql UPDATED 16.6.0 16.9.0
sass UPDATED 1.56.1 1.71.0

@github-actions github-actions bot removed the has conflicts Has conflicts to resolve before merging label Oct 25, 2024
@Tsiorifamonjena
feat(pci.private-network): decompose the structure of config page
dc4de7d 
ref: TAPC-1824
Signed-off-by: tsiorifamonjena <tsiorifamonjena.tianjanahary.ext@corp.ovh.com>

feat(pci.private-network): add constant and schema for form

ref: TAPC-1824
Signed-off-by: tsiorifamonjena <tsiorifamonjena.tianjanahary.ext@corp.ovh.com>
@Tsiorifamonjena Tsiorifamonjena force-pushed the feat/pci-private-network_subnet_tapc-1824 branch from 033936c to dc4de7d Compare October 25, 2024 13:28
@Tsiorifamonjena
feat(pci.private-network): implementing back button spec
76d4d4f 
ref: TAPC-1824
Signed-off-by: tsiorifamonjena <tsiorifamonjena.tianjanahary.ext@corp.ovh.com>
@Tsiorifamonjena
feat(pci.private-network): isolate and remove unecessary function called
a3a266a 
ref: TAPC-1824
Signed-off-by: tsiorifamonjena <tsiorifamonjena.tianjanahary.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
20 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

fredericvilcot
fredericvilcot approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@fredericvilcot fredericvilcot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredericvilcot fredericvilcot fredericvilcot approved these changes

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@tibs245 tibs245 Awaiting requested review from tibs245 tibs245 is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@MaximeBajeux MaximeBajeux Awaiting requested review from MaximeBajeux MaximeBajeux is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file feature New feature universe-public-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tsiorifamonjena @fredericvilcot