Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(kms): kms dashboard tests #13797

Open
wants to merge 2 commits into
base: release/enabler-w44
Choose a base branch
from
Open

feat(kms): kms dashboard tests #13797

wants to merge 2 commits into from

Conversation

rjamet-ovh
Copy link
Contributor

Question Answer
Branch? develop
Bug fix? no
New feature? no
Breaking change? no
Tickets Fix #MANAGER-15108
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

add kms dashboard tests

@rjamet-ovh rjamet-ovh requested review from a team as code owners October 25, 2024 14:46
@rjamet-ovh rjamet-ovh requested review from sidlynx, seven-amid, antonymarion, oalkabouss and JacquesLarique and removed request for a team October 25, 2024 14:46
@github-actions github-actions bot added enabler feature New feature labels Oct 25, 2024
Romain Jamet added 2 commits October 25, 2024 17:59
fix(kms): add test coverage
f82e6f5 
ref: MANAGER-15108

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
feat(kms): add TU kms dashboard
f3db30e 
ref: MANAGER-15108

Signed-off-by: Romain Jamet <romain.jamet.ext@corp.ovh.com>
@rjamet-ovh rjamet-ovh force-pushed the feat/MANAGER-15108-TU-kms-dashboard branch from a56b501 to f3db30e Compare October 25, 2024 15:59
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chipp972 chipp972 chipp972 approved these changes

@darsene darsene darsene approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@antonymarion antonymarion Awaiting requested review from antonymarion antonymarion is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@oalkabouss oalkabouss Awaiting requested review from oalkabouss oalkabouss is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
enabler feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rjamet-ovh @chipp972 @darsene