Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(account): move the code to the new app #13799

Open
wants to merge 2 commits into
base: feat/MANAGER-15021
Choose a base branch
from
Open

feat(account): move the code to the new app #13799

wants to merge 2 commits into from
+41,327 −118

Conversation

MaximeBajeux
Copy link
Contributor

Question Answer
Branch? master / release/** / develop
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

Maxime Bajeux added 2 commits October 22, 2024 11:59
feat(account): fix build issue
84670ad 
Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
feat(account): deplace code in the new app
e7cc923 
ref: MANAGER-15022

Signed-off-by: Maxime Bajeux <maxime.bajeux.ext@corp.ovh.com>
@MaximeBajeux MaximeBajeux requested review from a team as code owners October 25, 2024 16:04
@MaximeBajeux MaximeBajeux requested review from frenautvh, seven-amid, qpavy, ghyenne and darsene and removed request for a team October 25, 2024 16:04
@github-actions GitHub Actions
Copy link
Contributor

yarn.lock changes

Click to toggle table visibility
Name Status Previous Current
postcss UPDATED 8.4.41 8.4.47
tailwindcss UPDATED 3.4.4 3.4.14

@github-actions github-actions bot added the feature New feature label Oct 25, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
142 Security Hotspots
27.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@ghyenne ghyenne Awaiting requested review from ghyenne ghyenne is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@darsene darsene Awaiting requested review from darsene darsene is a code owner automatically assigned from ovh/team-manager-dev-angularjs

Assignees
No one assigned
Labels
container dependencies Pull requests that update a dependency file feature New feature translation required universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MaximeBajeux