Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(manager-components): fix services type #13806

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

fix(manager-components): fix services type #13806

wants to merge 2 commits into from

Conversation

chipp972
Copy link
Contributor

ref: ISSUE-13805

Question Answer
Branch? develop
Bug fix? yes
New feature? no
Breaking change? no
Tickets ISSUE-13805
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

fix(manager-components): fix services type
1454b6b 
ref: ISSUE-13805

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@chipp972 chipp972 requested review from a team as code owners October 28, 2024 09:40
@github-actions github-actions bot added the bug Something isn't working label Oct 28, 2024
@chipp972 chipp972 linked an issue Oct 28, 2024 that may be closed by this pull request
[manager-components]: fix services type #13805
Open
3 tasks
@chipp972 chipp972 requested a review from a team as a code owner October 28, 2024 10:28
feat(*): split services mock file
5570bff 
ref: ISSUE-13805

Signed-off-by: Nicolas Pierre-charles <nicolas.pierre-charles.ext@corp.ovh.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjamet-ovh rjamet-ovh rjamet-ovh approved these changes

@qpavy qpavy Awaiting requested review from qpavy qpavy is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sachinrameshn sachinrameshn Awaiting requested review from sachinrameshn sachinrameshn is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@JacquesLarique JacquesLarique Awaiting requested review from JacquesLarique JacquesLarique is a code owner automatically assigned from ovh/team-manager-dev-angularjs

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@seven-amid seven-amid Awaiting requested review from seven-amid seven-amid is a code owner automatically assigned from ovh/su-digital-tools-core-stack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working universe-bare-metal-cloud
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[manager-components]: fix services type
2 participants
@chipp972 @rjamet-ovh