Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(pci-load-balancer): add modal to change pool name #13815

Open
wants to merge 1 commit into
base: feat/DTCORE-2770
Choose a base branch
from

Conversation

kqesar
Copy link
Contributor

@kqesar kqesar commented Oct 28, 2024

ref: DTCORE-2652

Question Answer
Branch? feat/pci-load-balancer
Bug fix? yes/no
New feature? yes/no
Breaking change? yes/no
Tickets Fix #...
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Related

@kqesar kqesar requested review from a team as code owners October 28, 2024 14:29
@kqesar kqesar requested review from frenautvh, seven-amid, qpavy, ghyenne and darsene and removed request for a team October 28, 2024 14:29

// Invalidate cache for pool overview
await queryClient.invalidateQueries({
queryKey: ['pool'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
queryKey: ['pool'],
queryKey: ['pool', projectId, region],

ref: DTCORE-2652
Signed-off-by: Yoann Fievez <yoann.fievez@gmail.com>
Copy link

sonarcloud bot commented Oct 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants