Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pci-databases-analytics): hide queries statistics if engine is not pgsql #13816

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(pci-databases-analytics): hide queries statistics if engine is not pgsql #13816

wants to merge 1 commit into from
+5 −2

Conversation

jperchoc
Copy link
Contributor

@jperchoc jperchoc commented Oct 28, 2024 •
edited
Loading

DATATR-1619

Question Answer
Branch? master
Bug fix? yes
New feature? no
Breaking change? no
Tickets Fix #DATATR-1619
License BSD 3-Clause
  • Try to keep pull requests small so they can be easily reviewed.
  • Commits are signed-off
  • Only FR translations have been updated
  • Branch is up-to-date with target branch
  • Lint has passed locally
  • Standalone app was ran and tested locally
  • Ticket reference is mentioned in linked commits (internal only)
  • Breaking change is mentioned in relevant commits

Description

Hide the statistics for queries if engine is not pgsql

@github-actions github-actions bot added the bug Something isn't working label Oct 28, 2024
@jperchoc jperchoc marked this pull request as ready for review October 28, 2024 14:55
@jperchoc jperchoc requested review from a team as code owners October 28, 2024 14:55
@jperchoc jperchoc marked this pull request as draft October 28, 2024 14:55
@jperchoc jperchoc marked this pull request as ready for review October 28, 2024 14:58
@jperchoc jperchoc force-pushed the fix/pci-db-mysql-query-statistics branch from d484430 to c0af96b Compare October 28, 2024 15:07
@jperchoc
fix: hide queries statistics if engine is not pgsql
4b7871a 
DATATR-1619

Signed-off-by: Jonathan Perchoc <jonathan.perchoc@ovhcloud.com>
@jperchoc jperchoc force-pushed the fix/pci-db-mysql-query-statistics branch from c0af96b to 4b7871a Compare October 28, 2024 15:15
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abullet33 abullet33 abullet33 approved these changes

@sidlynx sidlynx Awaiting requested review from sidlynx sidlynx is a code owner automatically assigned from ovh/su-digital-tools-core-stack

@frenautvh frenautvh Awaiting requested review from frenautvh frenautvh is a code owner automatically assigned from ovh/su-digital-tools-core-stack

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jperchoc @abullet33