Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update verify_ssn.cc to fix new format #2971

Open
wants to merge 1 commit into
base: v3/master
Choose a base branch
from

Conversation

jakubsuchy
Copy link

Fixes #2970

@marcstern marcstern added the 3.x Related to ModSecurity version 3.x label Feb 1, 2024
@airween airween self-assigned this Feb 27, 2024
@airween
Copy link
Member

airween commented Feb 27, 2024

Hi @jakubsuchy,

thanks for first time contributing!

lidmodsecurity3 has an awesome regression test framework and many test cases. Could you add some new tests to check your modification to the existing one? You can add at least a new case with a new format.

After that (I hope) the CI workflow will start (seems like your PR wasn't checked yet).

@airween airween self-requested a review February 27, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Related to ModSecurity version 3.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

verifySSN: Area code can be larger than 740
3 participants