Skip to content
This repository has been archived by the owner on Jan 18, 2021. It is now read-only.

Make global TUS capability configurable #228

Merged
merged 2 commits into from
Jun 3, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented May 26, 2020

Added global TUS capability in the config structure.
Added config switches for the advertised max chunk size and http method
override.

  • adjust value semantics for tus_support and max_chunk_size (see original ticket)
  • add config switch to disable "tus_support" completely
  • add changelog entry

Requires cs3org/reva#775 to work.

@PVince81 PVince81 requested review from IljaN and refs May 26, 2020 14:19
@PVince81 PVince81 self-assigned this May 26, 2020
@update-docs
Copy link

update-docs bot commented May 26, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PVince81 PVince81 force-pushed the add-global-tus-capabilities branch from f2984dc to 35f6287 Compare May 26, 2020 14:24
@PVince81 PVince81 marked this pull request as draft May 28, 2020 09:46
@PVince81 PVince81 changed the title Add global TUS capability + some config Make global TUS capability configurable May 29, 2020
@PVince81
Copy link
Contributor Author

PVince81 commented May 29, 2020

Added global TUS capability in the config structure.
Added config switches for the advertised max chunk size and http method
override.
@PVince81 PVince81 force-pushed the add-global-tus-capabilities branch from 3d52593 to 4372c09 Compare June 2, 2020 09:05
@PVince81 PVince81 marked this pull request as ready for review June 2, 2020 09:08
@PVince81 PVince81 force-pushed the add-global-tus-capabilities branch from 4372c09 to 32306dc Compare June 2, 2020 09:46
@ownclouders
Copy link

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- pkg/command/frontend.go  1
         

See the complete overview on Codacy

@refs
Copy link
Member

refs commented Jun 3, 2020

@PVince81 merge or do you want to update reva dependency on the PR?

@PVince81
Copy link
Contributor Author

PVince81 commented Jun 3, 2020

@refs I usually prefer to update reva separately

@PVince81 PVince81 merged commit deb394d into master Jun 3, 2020
@delete-merged-branch delete-merged-branch bot deleted the add-global-tus-capabilities branch June 3, 2020 07:49
@refs
Copy link
Member

refs commented Jun 3, 2020

@refs I usually prefer to update reva separately

good, let's keep it that way 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants