-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
creates register (admin) pages #25
Conversation
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line no. 8 to 11 && 19 to 22.
Here I want to mention that it is good practice to write clean code by taking care of not write undesired comments and like wise include good comments like e.g. // sport image . or e.g. // textfield for name , // textfield for password as when giving style and theme to that widget ,it s child go to bottom and there is finding problem by the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 33 : give sufficient ', ' so the the format of the code is well structured.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Delete inbuilt flutter comments and add your own , e.g. // Intl is library used to Date-Format, Number-Format and classes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make Sure to take care of points which I have mentioned in the review box before making a next PR.
No description provided.