-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support choice of runner(s) #105
Open
jsa34
wants to merge
13
commits into
pa11y:main
Choose a base branch
from
jsa34:start-adding-axe-caps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
197c452
update pa11y
jsa34 47b4c7c
adding axe runner
jsa34 35395fa
adding axe runner
jsa34 9a5b5fb
Merge remote-tracking branch 'origin/master' into start-adding-axe-caps
jsa34 11d794b
Merge remote-tracking branch 'origin/start-adding-axe-caps' into star…
jsa34 c91fedc
update for allowing string to array runner list
jsa34 caeffa2
add a bit of trimming!
jsa34 7200a8a
handle null-ness
jsa34 36d2b21
handle null-ness correctly this time!
jsa34 a0c853b
accidently committing debug stuff
jsa34 ac00de7
Wasn't actually checking for string!
jsa34 305f6ba
forgot to remove logging!
jsa34 6c86bd3
make both runners default if none specified
jsa34 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -191,6 +191,7 @@ module.exports = function(app, callback) { | |||||
wait: (task.wait || 0), | ||||||
ignore: task.ignore, | ||||||
actions: task.actions || [], | ||||||
runners: possibleCsvListToArray(app.config.runners), | ||||||
chromeLaunchConfig: app.config.chromeLaunchConfig || {}, | ||||||
headers: task.headers || {}, | ||||||
log: { | ||||||
|
@@ -301,3 +302,12 @@ module.exports = function(app, callback) { | |||||
callback(errors, model); | ||||||
}); | ||||||
}; | ||||||
|
||||||
function possibleCsvListToArray(value) { | ||||||
if (Array.isArray(value)) { | ||||||
return value; | ||||||
} else if (typeof value === 'string') { | ||||||
return value.split(',').forEach(item => item.trim()); | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You need to use
Suggested change
|
||||||
} | ||||||
throw new TypeError('You have passed an empty string/array to this function. Please make sure you have specified a string or array.'); | ||||||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this not need to use
possibleCsvListToArray
? Additionally we should not default to using bothhtmlcs
andaxe
as this will break peoples dashboards who upgrade but don't add this configuration.