Dockerfile updated #181
Open
Dockerfile updated #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the image can be actually built
drizzt
reviewed
Dec 30, 2023
| RUN composer install --no-interaction --optimize-autoloader --no-dev --no-cache | ||
|
|
||
| EXPOSE 8080 | ||
| EXPOSE 9000 |
| && chmod -R 777 /var/www/html/ \ | ||
| && apk cache clean \ | ||
| && rm -rf /var/lib/apk/lists/* \ | ||
| && rm -rf /usr/bin/composer |
There was a problem hiding this comment.
I think you should use a multi-stage docker file https://docs.docker.com/build/building/multi-stage/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
Dockerfileworks and builds, I had to build my own image as I have an ARM processor. Aside from that, the image itself has its own NGINX, which doesn't work for my setup, and assumingly most of the docker setups of other people who host multiple frontends that are available for the public. I think you should add a section for setting up NGINX with PHP. New instance at: cringe.seitan-ayoub.lol