-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOPID-2322] - CieID Error handling #6306
Conversation
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6306 +/- ##
==========================================
- Coverage 48.42% 47.06% -1.36%
==========================================
Files 1488 1808 +320
Lines 31617 36781 +5164
Branches 7669 8785 +1116
==========================================
+ Hits 15311 17312 +2001
- Misses 16238 19413 +3175
+ Partials 68 56 -12
... and 1426 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
…o the LandingScreen
…mount component on error
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Short description
Added error and loading handling
List of changes proposed in this pull request
cie-ios:prod
andcie-ios:dev
react-native-webview
loader with theLoadingOverlay
component in therenderLoading
methodonHttpError
andonError
to usehandleLoadingError
functionisAuthenticationUrl
utility function to detect when to open theCieID
apphandleLoginFailure
function to properly redirect to theAuthErrorScreen
AuthErroComponent
Demo
iOS
Operation canceled
iOS-cancel-operation-cie-pin-available.mp4
iOS-cancel-operation-cie-pin-unavailable.mp4
iOS-deep-link-operation-cancel.mp4
Invalid operation
iOS-invalid-operation.mp4
Android
Operation canceled
android-cie-id-operation-interrupted-cie-pin-available.mp4
android-cie-id-operation-interrupted-cie-pin-not-available.mp4
android-cie-id-operation-cancel.mp4
How to test
Run the app in the local environment, and emulate what shown in the Demo videos
Important
Currently, the following errors are expected:
Android
CIEID_OPERATION_CANCEL
: Currently handled only on Android in the production environment.iOS (Deep link)
Both platforms
Clicking the "Cancel" CTA during the loading of the login screen.