Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-347] Remove react-native-text-input-mask build phase script on iOS #6310

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

LazyAfternoons
Copy link
Contributor

@LazyAfternoons LazyAfternoons commented Oct 19, 2024

Short description

This PR removes the build script patch for react-native-text-input-mask which is a removed dependency.

List of changes proposed in this pull request

  • Remove the workaround from the Build Phases.

How to test

# If you store DeriveData with relative path to the project folder, otherwise use Xcode to clean the build
> rm -rf ios/DerivedData 
> rm -rf ios/Pods
> cd ios && bundler exec pod install && cd .. 
> yarn react-native run-ios

This should also fix a warning we receive when building the iOS app.

@LazyAfternoons LazyAfternoons requested a review from a team as a code owner October 19, 2024 10:27
@LazyAfternoons LazyAfternoons changed the title [IOAPPX-347] chore: remove react-native-text-input-mask script [IOAPPX-347] Remove react-native-text-input-mask build phase script on iOS Oct 19, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-347] Remove react-native-text-input-mask build phase script on iOS chore(Cross): [IOAPPX-347] Chore: remove react-native-text-input-mask script Oct 19, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 19, 2024

Affected stories

  • ⚙️ IOAPPX-347: [io-app] Rimozione script in build phase per react-native-text-input-mask su iOS
    subtask of

Generated by 🚫 dangerJS against b52cda4

@LazyAfternoons LazyAfternoons changed the title chore(Cross): [IOAPPX-347] Chore: remove react-native-text-input-mask script chore(Cross): [IOAPPX-347] Remove react-native-text-input-mask build phase script on iOS Oct 19, 2024
Copy link

codecov bot commented Oct 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.72%. Comparing base (4f204b4) to head (b52cda4).
Report is 746 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6310      +/-   ##
==========================================
- Coverage   48.42%   47.72%   -0.70%     
==========================================
  Files        1488     1608     +120     
  Lines       31617    32262     +645     
  Branches     7669     7452     -217     
==========================================
+ Hits        15311    15398      +87     
- Misses      16238    16822     +584     
+ Partials       68       42      -26     

see 1664 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a6dac6...b52cda4. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants