-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: [IOBP-930] Remove payments redirect banner from wallet #6316
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6316 +/- ##
==========================================
- Coverage 48.42% 46.97% -1.45%
==========================================
Files 1488 1803 +315
Lines 31617 36550 +4933
Branches 7669 8699 +1030
==========================================
+ Hits 15311 17170 +1859
- Misses 16238 19323 +3085
+ Partials 68 57 -11
... and 1424 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the WalletPaymentsRedirectBanner
component is no longer used and will not be used in the future, what do you think about removing it from the codebase and all the related code, such as translation keys, the isWalletPaymentsRedirectBannerVisibleSelector
, and the shouldShowPaymentsRedirectBanner
preference from the persistor?
Good catch! I didn’t do that because I wasn’t sure if they might be useful in the future |
Removed reducers, actions and selectors used to display WalletPaymentsRedirectBanner
Remove unnecessary assertion since shouldShowPaymentsRedirectBanner has been removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
## Short description This pull request removes the banner that prompts users to go to the payments section when they want to pay a notice from the wallet screen. ## List of changes proposed in this pull request - Delete `WalletPaymentsRedirectBanner` component and its redux variable ## How to test - Navigate to the Portafoglio (Wallet) section. - Verify that the banner prompting for payment redirection no longer appears. --------- Co-authored-by: Alessandro <alessandro.izzo998@gmail.com>
Short description
This pull request removes the banner that prompts users to go to the payments section when they want to pay a notice from the wallet screen.
List of changes proposed in this pull request
WalletPaymentsRedirectBanner
component and its redux variableHow to test