Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [IOBP-930] Remove payments redirect banner from wallet #6316

Merged
merged 8 commits into from
Oct 22, 2024

Conversation

LeleDallas
Copy link
Contributor

@LeleDallas LeleDallas commented Oct 21, 2024

Short description

This pull request removes the banner that prompts users to go to the payments section when they want to pay a notice from the wallet screen.

List of changes proposed in this pull request

  • Delete WalletPaymentsRedirectBanner component and its redux variable

How to test

  • Navigate to the Portafoglio (Wallet) section.
  • Verify that the banner prompting for payment redirection no longer appears.

@pagopa-github-bot pagopa-github-bot changed the title chore: [IOBP-930] Remove payments redirect banner from wallet feat: [IOBP-930] Remove payments redirect banner from wallet Oct 21, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 21, 2024

Affected stories

  • 🌟 IOBP-930: [Portafoglio] Rimozione banner "Vuoi pagare un avviso: vai alla sezione pagamenti?"

Generated by 🚫 dangerJS against 4031bd0

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.97%. Comparing base (4f204b4) to head (4031bd0).
Report is 633 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6316      +/-   ##
==========================================
- Coverage   48.42%   46.97%   -1.45%     
==========================================
  Files        1488     1803     +315     
  Lines       31617    36550    +4933     
  Branches     7669     8699    +1030     
==========================================
+ Hits        15311    17170    +1859     
- Misses      16238    19323    +3085     
+ Partials       68       57      -11     
Files with missing lines Coverage Δ
ts/features/newWallet/screens/WalletHomeScreen.tsx 86.20% <ø> (+1.99%) ⬆️
ts/features/newWallet/store/actions/preferences.ts 100.00% <ø> (ø)
...s/features/newWallet/store/reducers/preferences.ts 81.81% <100.00%> (+12.58%) ⬆️
ts/features/newWallet/store/selectors/index.ts 88.23% <ø> (-11.77%) ⬇️

... and 1424 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfbe4aa...4031bd0. Read the comment docs.

Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the WalletPaymentsRedirectBanner component is no longer used and will not be used in the future, what do you think about removing it from the codebase and all the related code, such as translation keys, the isWalletPaymentsRedirectBannerVisibleSelector, and the shouldShowPaymentsRedirectBanner preference from the persistor?

@LeleDallas
Copy link
Contributor Author

Since the WalletPaymentsRedirectBanner component is no longer used and will not be used in the future, what do you think about removing it from the codebase and all the related code, such as translation keys, the isWalletPaymentsRedirectBannerVisibleSelector, and the shouldShowPaymentsRedirectBanner preference from the persistor?

Good catch! I didn’t do that because I wasn’t sure if they might be useful in the future

Removed reducers, actions and selectors used to display WalletPaymentsRedirectBanner
Remove unnecessary assertion since shouldShowPaymentsRedirectBanner has been removed
Copy link
Contributor

@Hantex9 Hantex9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LeleDallas LeleDallas merged commit ffdc0ea into master Oct 22, 2024
13 checks passed
@LeleDallas LeleDallas deleted the IOBP-930-remove-pay-banner-in-wallet branch October 22, 2024 14:07
LazyAfternoons pushed a commit that referenced this pull request Oct 23, 2024
## Short description
This pull request removes the banner that prompts users to go to the
payments section when they want to pay a notice from the wallet screen.

## List of changes proposed in this pull request
- Delete `WalletPaymentsRedirectBanner` component and its redux variable

## How to test
- Navigate to the Portafoglio (Wallet) section.
- Verify that the banner prompting for payment redirection no longer
appears.

---------

Co-authored-by: Alessandro <alessandro.izzo998@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
IO-Bonus e pagamenti IO - Bonus e pagamenti
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants