-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Cross): [IOAPPX-414] Add NativeStackNavigator
to the Design System section
#6340
base: master
Are you sure you want to change the base?
Conversation
NativeStackNavigator
to the Design System sectionNativeStackNavigator
to the Design System section
Affected stories
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6340 +/- ##
==========================================
- Coverage 48.42% 47.71% -0.72%
==========================================
Files 1488 1609 +121
Lines 31617 32230 +613
Branches 7669 7436 -233
==========================================
+ Hits 15311 15378 +67
- Misses 16238 16810 +572
+ Partials 68 42 -26
... and 1654 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Important
This is a reproposal of the following PR, merged and then reverted after concerns about Android builds:
NativeStackNavigator
to the Design System section #5424Short description
This PR adds the new
NativeStackNavigator
to the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.List of changes proposed in this pull request
@react-navigation/native-stack
dependencyreact-native-screens
dependency with the latest versionHow to test
Launch the app, go to the Design System section and check if everything is OK.