Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Cross): [IOAPPX-414] Add NativeStackNavigator to the Design System section #6340

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

dmnplb
Copy link
Contributor

@dmnplb dmnplb commented Oct 28, 2024

Important

This is a reproposal of the following PR, merged and then reverted after concerns about Android builds:

Short description

This PR adds the new NativeStackNavigator to the Design System section. This change enables a true native modal behaviour on iOS (including pull down to dismiss), other than a native navigation on both platforms.

List of changes proposed in this pull request

  • Add @react-navigation/native-stack dependency
  • Update react-native-screens dependency with the latest version

How to test

Launch the app, go to the Design System section and check if everything is OK.

@dmnplb dmnplb added the Design System New visual language and reduction of previous UI clutter label Oct 28, 2024
@pagopa-github-bot pagopa-github-bot changed the title [IOAPPX-414] Add NativeStackNavigator to the Design System section chore(Cross): [IOAPPX-414] Add NativeStackNavigator to the Design System section Oct 28, 2024
@pagopa-github-bot
Copy link
Collaborator

pagopa-github-bot commented Oct 28, 2024

Affected stories

  • ⚙️ IOAPPX-414: [io-app] Aggiunta della navigazione nativa all'interno della sezione DS

Generated by 🚫 dangerJS against 58525d0

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 47.71%. Comparing base (4f204b4) to head (4dfe3d4).
Report is 735 commits behind head on master.

Files with missing lines Patch % Lines
ts/features/design-system/navigation/navigator.tsx 9.09% 10 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6340      +/-   ##
==========================================
- Coverage   48.42%   47.71%   -0.72%     
==========================================
  Files        1488     1609     +121     
  Lines       31617    32230     +613     
  Branches     7669     7436     -233     
==========================================
+ Hits        15311    15378      +67     
- Misses      16238    16810     +572     
+ Partials       68       42      -26     
Files with missing lines Coverage Δ
ts/features/design-system/navigation/routes.ts 100.00% <ø> (ø)
ts/features/design-system/navigation/navigator.tsx 14.28% <9.09%> (-8.58%) ⬇️

... and 1654 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbdc20b...4dfe3d4. Read the comment docs.

---- 🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cross Design System New visual language and reduction of previous UI clutter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants