-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(IT Wallet): [SIW-1851] Add ephemeral credential Trustmark QR Code #6433
Open
mastro993
wants to merge
21
commits into
master
Choose a base branch
from
SIW-1851-update-credential-trustmark-generation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
chore(IT Wallet): [SIW-1851] Add ephemeral credential Trustmark QR Code #6433
mastro993
wants to merge
21
commits into
master
from
SIW-1851-update-credential-trustmark-generation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pagopa-github-bot
changed the title
[SIW-1851] Add ephemeral credential Trustmark QR Code
chore(IT Wallet): [SIW-1851] Add ephemeral credential Trustmark QR Code
Nov 20, 2024
mastro993
requested review from
dmnplb,
ChrisMattew,
gispada,
freddi301 and
a team
as code owners
November 20, 2024 16:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
This PR introduces a new logic for generating a credential trustmark QR Code along with an updated UI. The logic is implemented using an XState machine, which manages the creation and automatic refresh of the QR Code upon expiration. Before generating the trustmark, the WIA validity is verified, and a new one is fetched if necessary.
List of changes proposed in this pull request
io-react-native-wallet
version to0.24.1
react-native-qrcode-svg
package for QR image generationQrCodeImage
component:value
can now beundefined
, allowing the display of a placeholder when QR Code is not availablecorrectionLevel
as a prop.react-native-qrcode-svg
instead ofrn-qr-generator
for generating QR Code imagesItwCredentialTrustmark
component tots/features/itwallet/trustmark/components
folderitwTrustmarkUtils.ts
in thets/features/itwallet/common/utils
folder, containing functions for obtaining trustmarks usingio-react-native-wallet
APIsItwCredentialTrustmarkScreen
to handle trustmark generation and displayitwTrustmarkMachine
to manage the trustmark QR Code lifecycle, including generation and refresh logic.generateTrustmarkUrl
function fromitwCredentialUtils.ts
(no longer needed).useMaxBrightness
utility refactoring:How to test
This PR should be tested on iOS and Android.
GET /token
endpoint using a proxy (e.g., Proxyman):Preview
Some parts of the following video are censored for privacy reasons
test.mp4