Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metavar for Choice options when show_choices=False #2365

Merged
merged 5 commits into from
Nov 2, 2024
Merged

Fix metavar for Choice options when show_choices=False #2365

merged 5 commits into from
Nov 2, 2024

Commits on Nov 2, 2024

  1. fix(types): Choice.get_metavar() uses metavars of choices if `show_… 

    …choices=False`
    @mrmups @AndreasBackx
    mrmups authored and AndreasBackx committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    7a76748 View commit details
    Browse the repository at this point in the history

  2. fix: Keep metavar order when making choices_str

    @mrmups @AndreasBackx
    mrmups authored and AndreasBackx committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    04c8c39 View commit details
    Browse the repository at this point in the history

  3. fix: Ignore typecheck on param.show_choices

    @mrmups @AndreasBackx
    mrmups authored and AndreasBackx committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    96bf716 View commit details
    Browse the repository at this point in the history

  4. fix: Do not wrap single choice metavar in braces

    @mrmups @AndreasBackx
    mrmups authored and AndreasBackx committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    b2642d4 View commit details
    Browse the repository at this point in the history

  5. Revert inconsistent choice metavar formatting

    @mrmups @AndreasBackx
    mrmups authored and AndreasBackx committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    f7d98fe View commit details
    Browse the repository at this point in the history