Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core.py: Make error messages more verbose #2453

Merged
merged 60 commits into from
Oct 26, 2024
Merged

core.py: Make error messages more verbose #2453

merged 60 commits into from
Oct 26, 2024

Conversation

jaseg
Copy link
Contributor

@jaseg jaseg commented Feb 16, 2023

Especially the option one is hard to debug without this information since the stacktrace points at the command wrapper instead of the actual source line of the bad option declaration decorator.

Issue: #2452

This PR makes the "Could not determine name for option" and one similar error message in core.py more descriptive by including the name of the offending declaration.

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

davidism and others added 30 commits March 28, 2022 10:46
@davidism
start version 8.2.0
f467dd3
@davidism
Merge branch '8.1.x'
c1d0729
@davidism
Merge branch '8.1.x'
a8910b3
@dependabot
Bump actions/cache from 2 to 3.0.1
1d933e3 
Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3.0.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v2...v3.0.1)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/checkout from 2 to 3
4213adc 
Bumps [actions/checkout](https://github.com/actions/checkout) from 2 to 3.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@v2...v3)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Merge pull request pallets#2239 from pallets/dependabot/github_action…
757c4e6 
…s/actions/cache-3.0.1

Bump actions/cache from 2 to 3.0.1
@davidism
Merge pull request pallets#2240 from pallets/dependabot/github_action…
808fccf 
…s/actions/checkout-3

Bump actions/checkout from 2 to 3
@davidism
Merge branch '8.1.x'
14472ff
@davidism
Merge branch '8.1.x'
6bd8e56
@davidism
Merge branch '8.1.x'
0aec116
@dependabot
Bump actions/cache from 3.0.1 to 3.0.2
50ab582 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.1...v3.0.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Merge pull request pallets#2266 from pallets/dependabot/github_action…
c96545f 
…s/actions/cache-3.0.2

Bump actions/cache from 3.0.1 to 3.0.2
@dependabot
Bump actions/cache from 3.0.2 to 3.0.3
31df6fa 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.2...v3.0.3)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Merge pull request pallets#2301 from pallets/dependabot/github_action…
2f9b0f8 
…s/actions/cache-3.0.3

Bump actions/cache from 3.0.2 to 3.0.3
@dependabot
Bump actions/cache from 3.0.3 to 3.0.4
2967b15 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.3 to 3.0.4.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.3...v3.0.4)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/setup-python from 3 to 4
de533e5 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 3 to 4.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@v3...v4)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Merge pull request pallets#2314 from pallets/dependabot/github_action…
3d84c53 
…s/actions/cache-3.0.4

Bump actions/cache from 3.0.3 to 3.0.4
@davidism
Merge pull request pallets#2315 from pallets/dependabot/github_action…
dc918b4 
…s/actions/setup-python-4

Bump actions/setup-python from 3 to 4
@dependabot
Bump actions/cache from 3.0.4 to 3.0.5
d11c46a 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.4 to 3.0.5.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.4...v3.0.5)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Merge pull request pallets#2329 from pallets/dependabot/github_action…
08f71b0 
…s/actions/cache-3.0.5

Bump actions/cache from 3.0.4 to 3.0.5
@dependabot
Bump actions/cache from 3.0.5 to 3.0.8 (pallets#2349)
fb43272 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.5 to 3.0.8.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.5...v3.0.8)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
Bump actions/cache from 3.0.8 to 3.0.9 (pallets#2364)
2b60d81
@dependabot
Bump actions/cache from 3.0.9 to 3.0.11 (pallets#2391)
c65c6ad
@davidism
Merge branch '8.1.x'
5e75fe7
@dependabot
Bump actions/cache from 3.0.11 to 3.2.2
e3467ff 
Bumps [actions/cache](https://github.com/actions/cache) from 3.0.11 to 3.2.2.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@v3.0.11...v3.2.2)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump dessant/lock-threads from 3 to 4
687fc3e 
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads) from 3 to 4.
- [Release notes](https://github.com/dessant/lock-threads/releases)
- [Changelog](https://github.com/dessant/lock-threads/blob/master/CHANGELOG.md)
- [Commits](dessant/lock-threads@v3...v4)

---
updated-dependencies:
- dependency-name: dessant/lock-threads
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Bump actions/cache from 3.0.11 to 3.2.2 (pallets#2425)
0cc89ad
@davidism
Bump dessant/lock-threads from 3 to 4 (pallets#2426)
9595a19
@davidism
Merge branch '8.1.x'
19da7c1
@davidism
set workflow permissions
725e3e4
davidism and others added 20 commits February 7, 2023 07:20
@davidism
Merge branch '8.1.x'
fc29730
@jaseg
core.py: Make error messages more verbose
0e6e8d3 
Especially the option one is hard to debug without this information since the stacktrace points at the command wrapper instead of the actual source line of the bad option declaration decorator.
@dependabot
Bump actions/cache from 3.2.4 to 3.2.6
3b8e89f 
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.4 to 3.2.6.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@627f0f4...69d9d44)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump slsa-framework/slsa-github-generator from 1.4.0 to 1.5.0
7121d43 
Bumps [slsa-framework/slsa-github-generator](https://github.com/slsa-framework/slsa-github-generator) from 1.4.0 to 1.5.0.
- [Release notes](https://github.com/slsa-framework/slsa-github-generator/releases)
- [Changelog](https://github.com/slsa-framework/slsa-github-generator/blob/main/CHANGELOG.md)
- [Commits](slsa-framework/slsa-github-generator@v1.4.0...v1.5.0)

---
updated-dependencies:
- dependency-name: slsa-framework/slsa-github-generator
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Bump actions/cache from 3.2.4 to 3.2.6 (pallets#2458)
7ab7174
@davidism
Bump slsa-framework/slsa-github-generator from 1.4.0 to 1.5.0 (pallet…
58c2d97 
…s#2459)
@dependabot
Bump actions/cache from 3.2.6 to 3.3.1
c604cc8 
Bumps [actions/cache](https://github.com/actions/cache) from 3.2.6 to 3.3.1.
- [Release notes](https://github.com/actions/cache/releases)
- [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md)
- [Commits](actions/cache@69d9d44...88522ab)

---
updated-dependencies:
- dependency-name: actions/cache
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.8.4
fe1d6d3 
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.6.4 to 1.8.4.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@c7f29f7...29930c9)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump actions/checkout from 3.3.0 to 3.5.0
3c30fe4 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.3.0 to 3.5.0.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@ac59398...8f4b7f8)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Bump actions/checkout from 3.3.0 to 3.5.0 (pallets#2479)
19a708f
@davidism
Bump actions/cache from 3.2.6 to 3.3.1 (pallets#2477)
e581ee6
@davidism
Bump pypa/gh-action-pypi-publish from 1.6.4 to 1.8.4 (pallets#2478)
1de080b
@dependabot
Bump actions/setup-python from 4.5.0 to 4.6.0
5a44eec 
Bumps [actions/setup-python](https://github.com/actions/setup-python) from 4.5.0 to 4.6.0.
- [Release notes](https://github.com/actions/setup-python/releases)
- [Commits](actions/setup-python@d27e3f3...57ded4d)

---
updated-dependencies:
- dependency-name: actions/setup-python
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5
f312689 
Bumps [pypa/gh-action-pypi-publish](https://github.com/pypa/gh-action-pypi-publish) from 1.8.4 to 1.8.5.
- [Release notes](https://github.com/pypa/gh-action-pypi-publish/releases)
- [Commits](pypa/gh-action-pypi-publish@29930c9...0bf742b)

---
updated-dependencies:
- dependency-name: pypa/gh-action-pypi-publish
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Bump actions/setup-python from 4.5.0 to 4.6.0 (pallets#2504)
2cfb61e
@dependabot
Bump actions/checkout from 3.5.0 to 3.5.2
df861db 
Bumps [actions/checkout](https://github.com/actions/checkout) from 3.5.0 to 3.5.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8f4b7f8...8e5e7e5)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@davidism
Bump actions/checkout from 3.5.0 to 3.5.2 (pallets#2506)
1087659
@davidism
Bump pypa/gh-action-pypi-publish from 1.8.4 to 1.8.5 (pallets#2505)
cd7b51c
@saroad2
Merge branch '8.1.x'
b0538df
@saroad2
Merge branch 'main' into main
c212581
@davidism davidism added this to the 8.2.0 milestone Jul 4, 2023
@AndreasBackx AndreasBackx mentioned this pull request Oct 20, 2024
Open
39 tasks
@AndreasBackx AndreasBackx modified the milestones: 8.2.0, 8.1.8 Oct 26, 2024
@AndreasBackx AndreasBackx mentioned this pull request Oct 26, 2024
Open
9 tasks
@AndreasBackx AndreasBackx changed the base branch from main to stable October 26, 2024 15:23
@AndreasBackx AndreasBackx merged commit 8fa833e into pallets:stable Oct 26, 2024
12 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
8.1.8
Development

Successfully merging this pull request may close these issues.
4 participants
@jaseg @davidism @AndreasBackx @saroad2