Skip to content

Commit

Permalink
Translate more banned import config to ruff
Browse files Browse the repository at this point in the history
  • Loading branch information
tqa236 committed Feb 13, 2024
1 parent 1d7aedc commit ad0f549
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 4 deletions.
4 changes: 2 additions & 2 deletions doc/make.py
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ def html(self):
ret_code = self._sphinx_build("html")
zip_fname = os.path.join(BUILD_PATH, "html", "pandas.zip")
if os.path.exists(zip_fname):
os.remove(zip_fname)
os.remove(zip_fname) # noqa: TID251

if ret_code == 0:
if self.single_doc_html is not None:
Expand Down Expand Up @@ -285,7 +285,7 @@ def zip_html(self) -> None:
"""
zip_fname = os.path.join(BUILD_PATH, "html", "pandas.zip")
if os.path.exists(zip_fname):
os.remove(zip_fname)
os.remove(zip_fname) # noqa: TID251
dirname = os.path.join(BUILD_PATH, "html")
fnames = os.listdir(dirname)
os.chdir(dirname)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def test_series_setitem(indexer):

# using custom check instead of tm.assert_produces_warning because that doesn't
# fail if multiple warnings are raised
with pytest.warns() as record:
with pytest.warns() as record: # noqa: TID251
df["a"][indexer] = 0
assert len(record) == 1
assert record[0].category == ChainedAssignmentError
Expand Down
11 changes: 11 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,17 @@ exclude = [

[tool.ruff.lint.flake8-tidy-imports.banned-api]
"urllib.request.urlopen".msg = "Use pandas.io.common.urlopen instead of urllib.request.urlopen"
# numpy.random is banned but np.random is not. Is this intentional?
# "numpy.random".msg = "Do not use numpy.random"
"pytest.warns".msg = "Use tm.assert_produces_warning instead of pytest.warns"
"pytest.xfail".msg = "Use pytest.mark.xfail instead of pytest.xfail"
"conftest".msg = "No direct imports from conftest"
"numpy.testing".msg = "Do not use numpy.testing"
# "numpy.array_equal".msg = "Do not use numpy.array_equal" # Used in pandas/core
"unittest.mock".msg = "use pytest builtin monkeypatch fixture instead"
"os.remove".msg = "Do not use os.remove"



[tool.ruff.per-file-ignores]
# relative imports allowed for asv_bench
Expand Down
2 changes: 1 addition & 1 deletion web/tests/test_pandas_web.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
from unittest.mock import (
from unittest.mock import ( # noqa: TID251
mock_open,
patch,
)
Expand Down

0 comments on commit ad0f549

Please sign in to comment.