Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Allow no argument in code_checks #56751

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

#56408 introduced set -u, meaning the script will fail when using any unset variable. This includes $1.

@rhshadrach rhshadrach added Bug CI Continuous Integration labels Jan 6, 2024
@rhshadrach rhshadrach added this to the 3.0 milestone Jan 6, 2024
@rhshadrach rhshadrach requested a review from mroeschke as a code owner January 6, 2024 14:19
@mroeschke mroeschke merged commit 04b45b1 into pandas-dev:main Jan 8, 2024
54 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the bug_ci_code_checks branch January 8, 2024 00:34
pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CI Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants