Translate more banned import config to ruff #57283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 8, 2024
| "pytest.xfail".msg = "Use pytest.mark.xfail instead of pytest.xfail" | ||
| "conftest".msg = "No direct imports from conftest" | ||
| "numpy.testing".msg = "Do not use numpy.testing" | ||
| # "numpy.array_equal".msg = "Do not use numpy.array_equal" # Used in pandas/core |
There was a problem hiding this comment.
Could we just ignore it's usage in pandas/core?
There was a problem hiding this comment.
AFAIK, We can only ignore TID251 as a whole, we can't just ignore enforcing this rule for numpy.array_equal in pandas/core
There was a problem hiding this comment.
Gotcha. Can we remove some of the old checks that are covered by this section?
There was a problem hiding this comment.
it's done in the latest commit, you can take a look.
tqa236
force-pushed
the
use-ruff-for-banned-import
branch
from
02627df to
07c9f0b
Compare
tqa236
force-pushed
the
use-ruff-for-banned-import
branch
from
07c9f0b to
e7b8912
Compare
mroeschke
approved these changes
Feb 13, 2024
|
Thanks @tqa236 |
pmhatre1
pushed a commit
to pmhatre1/pandas-pmhatre1
that referenced
this pull request
May 7, 2024
* Translate more banned import config to ruff * Remove redundant rules
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate some config in
unwanted-patterns-in-teststoruff. I think the main selling point ofruffhere is just the ease of implementing new rules, like the currently unenabledpytest.warnsone.The major difference is that
unwanted-patterns-in-testsis currently only enabled inpandas/testswhile with this implementation,TID251will be enabled globally.There are several approaches we can explore to reconcile the 2 behaviors.
pygrep) for the restpandasdoesn't use it at the moment, so this will be a fairly big change)There's an open issue to track the progress of flat configuration, which allows us to keep all rules within 1 config file, but there's not much progress lately.