Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEPR: revert enforcing the deprecation of exposing blocks in core.internals and deprecate with FutureWarning #58715

Conversation

natmokval
Copy link
Contributor

xref #58467

@natmokval natmokval marked this pull request as ready for review May 15, 2024 12:13
@natmokval
Copy link
Contributor Author

I reverted the removal of Block and ExtensionBlock from core.internals, and replaced DeprecationWarning with FutureWarning. I think CI failures are unrelated to my changes.

@jorisvandenbossche could you please take a look at my changes? Is that what you meant in your comment in #58467?

Copy link
Contributor

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Jun 15, 2024
@mroeschke
Copy link
Member

Looks like this PR is fairly stale so closing to clear the queue, but happy to reopen at a later time

…osing-blocks-core-internals-replace-DeprecationWarning-FutureWarning
Copy link
Contributor

github-actions bot commented Nov 8, 2024

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Nov 8, 2024
@jorisvandenbossche jorisvandenbossche added Internals Related to non-user accessible pandas implementation Deprecate Functionality to remove in pandas and removed Stale labels Nov 8, 2024
@jorisvandenbossche jorisvandenbossche added this to the 2.3 milestone Nov 8, 2024
…osing-blocks-core-internals-replace-DeprecationWarning-FutureWarning
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the slow follow-up, but thanks for the PR @natmokval!

@jorisvandenbossche jorisvandenbossche merged commit 9b16b9e into pandas-dev:main Nov 8, 2024
51 checks passed
@pandas-dev pandas-dev deleted a comment from lumberbot-app bot Nov 8, 2024
@jorisvandenbossche jorisvandenbossche modified the milestones: 2.3, 3.0 Nov 8, 2024
@jorisvandenbossche
Copy link
Member

(accidentally added this to the 2.3 milestone instead of 3.0, this change of course does not need to be backported because the related change is only on main)

ZKaoChi pushed a commit to ZKaoChi/pandas that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecate Functionality to remove in pandas Internals Related to non-user accessible pandas implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants