TST: Update IntervalArray min/max test to fail on changed default skipna #59747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsngn
changed the title
|
@mroeschke Could you take a look? Thank you! |
mroeschke
approved these changes
Sep 9, 2024
|
Thanks @jsngn |
ammar-qazi
pushed a commit
to ammar-qazi/pandas
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type annotations to new arguments/methods/functions.Not applicableAdded an entry in the latestNot applicabledoc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Before, if the line core/arrays/interval.py:866 is changed from
def min(self, *, axis: AxisInt | None = None, skipna: bool = True) -> IntervalOrNA:todef min(self, *, axis: AxisInt | None = None, skipna: bool = False) -> IntervalOrNA:, all tests still passed. Now they will fail if the defaultskipnaparam is updated, perhaps mistakenly.Applies to
max()method too since they are tested in the same test function.