Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some common params for mmdc #44

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ngocptblaplafla
Copy link

@ngocptblaplafla ngocptblaplafla commented Oct 2, 2024

Example with all options supported

diagram:
  engine:
    mermaid:
      execpath: /usr/local/bin/mmdc
      theme: default
      configFile: 'some file like https://mermaid.js.org/schemas/config.schema.json'
      cssFile: your-theme-variables.json
      puppeteerConfigFile: /etc/puppeteer-conf.json

@tarleb
Copy link
Member

tarleb commented Oct 2, 2024

Good idea, thank you! Pandoc uses lisp-case for variables, so it would be good if we could do the same here.

The test failure is due to the images differing. That's why we're not using embed-resources, we just want to make sure that an image is generated.

@tarleb
Copy link
Member

tarleb commented Oct 2, 2024

It would also be important to have this new behavior documented somewhere.

@ngocptblaplafla
Copy link
Author

It would also be important to have this new behavior documented somewhere.

I haven't found anything related yet. I used mmdc -h for getting it's params. Even puppeteerConfigFile's shortcut params (-p) doesn't work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants