Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Output target chunks to logs? #656

Open
jbusecke opened this issue Nov 28, 2023 · 1 comment
Open

Output target chunks to logs? #656

jbusecke opened this issue Nov 28, 2023 · 1 comment

Comments

@jbusecke
Copy link
Contributor

With the additions of the dynamic chunking function I think it would be great to add some logging that shows the target chunks that are actually passed internally.
I believe that will make debugging recipes on e.g. Dataflow much easier.
@cisaacstern
Copy link
Member

Makes total sense, and in general we are too thin on logs.

As I think we've discussed, logging seems to need to be at INFO level or above to get picked up by Dataflow.

PRs welcome! 😄

jbusecke added a commit that referenced this issue Nov 29, 2023
@jbusecke
Add logging to StoreToZarr
7223107 
#656 
I also added the full target here, because that might be helpful to have?
@jbusecke jbusecke mentioned this issue Nov 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbusecke @cisaacstern