Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging to StoreToZarr #657

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Add logging to StoreToZarr #657

merged 2 commits into from
Feb 13, 2024

Conversation

jbusecke
Copy link
Contributor

#656
I also added the full target here, because that might be helpful to have?

#656 
I also added the full target here, because that might be helpful to have?
Co-authored-by: Charles Stern <62192187+cisaacstern@users.noreply.github.com>
@cisaacstern
Copy link
Member

@jbusecke have you confirmed anecdotally by running this that the logs write what you expect/desire them to?

@jbusecke
Copy link
Contributor Author

Hmmm not really. I havent run things on a PR branch in a bit lol. Let me check this, BRB

@jbusecke
Copy link
Contributor Author

Testing over at leap-stc/cmip6-leap-feedstock#79

@jbusecke
Copy link
Contributor Author

Hmmmm so over at leap-stc/cmip6-leap-feedstock#79 I specified to install -recipes from this branch, and the install seems to work.

But for e.g. one of the successful jobs im not able to find anything matching Storing Zarr with.

So either this does not work, or I am a moron with the logs (highly likely). @cisaacstern if you have a minute, could you take a stab at the logs (you should have access) and confirm my finding?

@moradology
Copy link
Contributor

I'm curious about the way this was run. If it was done in a local runner with multi_processing, I'd expect logging to be swallowed on executor processes even if this is defined correctly. Either way, the logging is written correctly here and if there are more general logging difficulties we should address them elsewhere. Going to merge this in as it is incredibly unlikely to cause trouble for us

@moradology moradology merged commit 93bdfab into main Feb 13, 2024
7 checks passed
@moradology moradology deleted the chunk-log branch February 13, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants