Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG-9246 — Fix mobile menu #9250

Merged
merged 3 commits into from
Oct 9, 2024
Merged

BUG-9246 — Fix mobile menu #9250

merged 3 commits into from
Oct 9, 2024

Conversation

mel-miller
Copy link
Member

@mel-miller mel-miller commented Oct 9, 2024

Summary

Fixes: #9246

  • Updates pds-toolkit-react to dev.168
  • Adds PDS GlobalWrapper (which includes the PDS ResponsiveContext provider)
  • Creates MOBILE_MENU_BREAKPOINT to apply to items not yet handled by ResponsiveContext

Bonus update:

  • Update PDS InputText for TextInput — the former is deprecated and will be removed before PDS 1.0.0 release.

@mel-miller mel-miller self-assigned this Oct 9, 2024
@mel-miller mel-miller requested a review from a team as a code owner October 9, 2024 20:38
@mel-miller mel-miller marked this pull request as draft October 9, 2024 20:38
Update PDS `InputText` for `TextInput` — the former is deprecated and will be removed before PDS 1.0.0 release.
Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9250-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

Copy link

⚡ Deployed with Pantheon Decoupled

This build was successfully deployed with Pantheon. You can track the build logs here.

👀 Preview: https://pr-9250-documentation.appa.pantheon.site
🛠️ Manage in Pantheon: https://dashboard.pantheon.io/site/2b30153f-e8b1-4427-b076-6109e704ba5d/overview

@mel-miller mel-miller marked this pull request as ready for review October 9, 2024 21:24
@rachelwhitton rachelwhitton merged commit 29fdb89 into main Oct 9, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Main site nav broken for mobile
2 participants