[ LOPS-1538 ] Cache the terminus directory and only add token if not already logged in

[stovak]

No description provided.

[G-Rath]

fwiw while I've not dig into how Terminus sessions actually work, I expect this will break for repositories that use multiple machine tokens because it isn't included in your cache key.

I'm not sure if it's safe to include it in there either, and unfortunately GHA only supports hashFiles so you'd need to write it to a file first to determine its hash

[stovak]

@G-Rath the problem that we're having is people running a bunch of builds and running afoul of our internal API resource limits. How common is using multiple machine tokens for terminus in a CI environment...??? I can't think of a use-case.

Also, yes, you are correct. It will break that.

[G-Rath]

With Pantheons current permission model I don't think there is a strong usecase, but I do live in hope it'll be improved at some point to allow us security folk to better lockdown our CIs 😉

But I know that won't be an overnight thing so I mainly mention this for completeness - at this point because of how niche the usecase is it's probably not even worth having an input to allow disabling the cache...

Something else to consider though is the lifetime of the session - am I right in thinking auth:login first checks if a valid session exists already, and only actually hits the API if its expired?

[kyletaylored]

I've integrated the source code from Lullabot's GitHub Action (#18) so that their action could be deprecated (talked with @penyaskito yesterday about this).

1. Cache implemented for sharing session across jobs
2. Session is encrypted using openssl / aes-256 before being stored into cache
3. Session is scoped to workflow run (re-running same workflow will use existing cache, new workflows create new session)

You can see a successful run of it here (see embedded steps in primary job and child jobs): https://github.com/the-scranton-branch/Scranton-WordPress/actions/runs/8206546810/job/22454187954

[kporras07]

Looks great!

[kyletaylored]

This also fixes #18 as it incorporates some of the code natively versus referencing it. Will close that PR.