Add lookup_chain customizability #162
Merged
+89
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Spone is there anything I need to do to get this PR merged? |
|
I just want @nicolas-brousse to have a look before we merge this! Thanks for your patience :) |
|
Hi @joelzwarrington looks good to me. Thank you for this PR and your patience! Could you add a line in the Changelog and rebase from |
|
Need this 🙏🏻 |
joelzwarrington
force-pushed
the
optional-component-suffix
branch
from
5c36856
to
3ec1381
Compare
nicolas-brousse
approved these changes
Jul 17, 2024
Spone
approved these changes
Jul 17, 2024
|
hey @Spone / @nicolas-brousse do you have any idea when a new version will be released? Are there any other features you want included before that happens? I'm currently using the git source in bundler but would be nice to use versions from https://rubygems.org |
|
I didn't have time yesterday to do it after merging this. But I plan to do it today |
|
@joelzwarrington |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Componentsuffix optional in lookup #80Adds configuration to determine how components are found, so one wouldn't need to use the
Componentsuffix in their components.Added documentation to the README.md to configure this option