Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: upgrade to DRF 3.15 #7134

Merged
merged 6 commits into from
Jul 9, 2024
Merged

Chore: upgrade to DRF 3.15 #7134

merged 6 commits into from
Jul 9, 2024

Conversation

shamoon
Copy link
Member

@shamoon shamoon commented Jun 30, 2024

Proposed change

Not the prettiest, but workaround:

Welcome any feedback, of course.

Closes #(issue or discussion)

Type of change

  • Bug fix: non-breaking change which fixes an issue.
  • New feature / Enhancement: non-breaking change which adds functionality. Please read the important note above.
  • Breaking change: fix or feature that would cause existing functionality to not work as expected.
  • Documentation only.
  • Other. Please explain:

Checklist:

  • I have read & agree with the contributing guidelines.
  • If applicable, I have included testing coverage for new code in this PR, for backend and / or front-end changes.
  • If applicable, I have tested my code for new features & regressions on both mobile & desktop devices, using the latest version of major browsers.
  • If applicable, I have checked that all tests pass, see documentation.
  • I have run all pre-commit hooks, see documentation.
  • I have made corresponding changes to the documentation as needed.
  • I have checked my modifications for any breaking changes.

@shamoon shamoon requested a review from a team as a code owner June 30, 2024 15:20
@paperless-ngx-secretary paperless-ngx-secretary bot added backend non-trivial Requires approval by several team members labels Jun 30, 2024
@github-actions github-actions bot added the enhancement New feature label Jun 30, 2024
Copy link

codecov bot commented Jun 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.30%. Comparing base (064d384) to head (8cebe8c).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #7134      +/-   ##
==========================================
+ Coverage   97.28%   97.30%   +0.01%     
==========================================
  Files         443      443              
  Lines       18479    18484       +5     
  Branches     1473     1562      +89     
==========================================
+ Hits        17978    17985       +7     
+ Misses        501      496       -5     
- Partials        0        3       +3     
Flag Coverage Δ
backend 96.04% <100.00%> (+0.02%) ⬆️
frontend 98.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stumpylog
Copy link
Member

Overall, it's not terrible, though I do dislike continuing to work around their issues. It might be good though to upgrade, given there are some CVE fixes, and increased Django version support

dependabot bot and others added 5 commits July 9, 2024 09:39
Bumps the django group with 2 updates: [django-cors-headers](https://github.com/adamchainz/django-cors-headers) and [djangorestframework](https://github.com/encode/django-rest-framework).

Updates `django-cors-headers` from 4.3.1 to 4.4.0
- [Changelog](https://github.com/adamchainz/django-cors-headers/blob/main/CHANGELOG.rst)
- [Commits](adamchainz/django-cors-headers@4.3.1...4.4.0)

Updates `djangorestframework` from 3.14.0 to 3.15.2
- [Release notes](https://github.com/encode/django-rest-framework/releases)
- [Commits](encode/django-rest-framework@3.14.0...3.15.2)

---
updated-dependencies:
- dependency-name: django-cors-headers
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: django
- dependency-name: djangorestframework
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: django
...

Signed-off-by: dependabot[bot] <support@github.com>
@shamoon
Copy link
Member Author

shamoon commented Jul 9, 2024

Yea I defer to you, I didnt think the workarounds were too bad and would be stable even if they fix the issues but of course it's hard to know. the default=None one seems benign, the other is just kinda generalizing a workaround we already had. My motivation was just that based on what I've seen from that project I have limited faith for if / when these things will get sorted...

But again, defer to you!

@stumpylog
Copy link
Member

You're right I don't think waiting for them to resolve it will be viable. Slow is an understatement.

@shamoon shamoon merged commit bb83c1e into dev Jul 9, 2024
25 checks passed
@shamoon shamoon deleted the feature-drf-3.15 branch July 9, 2024 16:57
calvinbui added a commit to calvinbui/ansible-monorepo that referenced this pull request Jul 14, 2024
This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/paperless-ngx/paperless-ngx](https://github.com/paperless-ngx/paperless-ngx) | minor | `2.10.2` -> `2.11.0` |

---

### Release Notes

<details>
<summary>paperless-ngx/paperless-ngx (ghcr.io/paperless-ngx/paperless-ngx)</summary>

### [`v2.11.0`](https://github.com/paperless-ngx/paperless-ngx/releases/tag/v2.11.0): Paperless-ngx v2.11.0

[Compare Source](paperless-ngx/paperless-ngx@v2.10.2...v2.11.0)

#### paperless-ngx 2.11.0

> \[!NOTE]\
> This release marks the transition from Gotenberg v7 to v8, which is now required. Changing Gotenberg versions for most users is as simple as updating the docker tag in your compose file (see the example compose files).

##### Breaking Changes

-   Feature: Upgrade Gotenberg to v8 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7094](paperless-ngx/paperless-ngx#7094))

##### Features

-   Enhancement: disable add split button when approrpriate [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7215](paperless-ngx/paperless-ngx#7215))
-   Enhancement: wrapping of saved view fields d-n-d UI [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7216](paperless-ngx/paperless-ngx#7216))
-   Enhancement: support custom field icontains filter for select type [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7199](paperless-ngx/paperless-ngx#7199))
-   Feature: select custom field type [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7167](paperless-ngx/paperless-ngx#7167))
-   Feature: automatic sso redirect [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7168](paperless-ngx/paperless-ngx#7168))
-   Enhancement: show more columns in mail frontend admin [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7158](paperless-ngx/paperless-ngx#7158))
-   Enhancement: use request user as owner of split / merge docs [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7112](paperless-ngx/paperless-ngx#7112))
-   Enhancement: improve date parsing with accented characters [@&#8203;fdubuy](https://github.com/fdubuy) ([#&#8203;7100](paperless-ngx/paperless-ngx#7100))
-   Feature: improve history display of object names etc [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7102](paperless-ngx/paperless-ngx#7102))
-   Feature: Upgrade Gotenberg to v8 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7094](paperless-ngx/paperless-ngx#7094))

##### Bug Fixes

-   Fix: include documents in trash for existing asn check [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7189](paperless-ngx/paperless-ngx#7189))
-   Fix: include documents in trash in sanity check [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7133](paperless-ngx/paperless-ngx#7133))
-   Fix: handle errors for trash actions and only show documents user can restore or delete [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7119](paperless-ngx/paperless-ngx#7119))
-   Fix: dont include documents in trash in counts [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7111](paperless-ngx/paperless-ngx#7111))
-   Fix: use temp dir for split / merge [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7105](paperless-ngx/paperless-ngx#7105))

##### Maintenance

-   Chore: upgrade to DRF 3.15 [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7134](paperless-ngx/paperless-ngx#7134))
-   Chore(deps): Bump docker/build-push-action from 5 to 6 in the actions group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7125](paperless-ngx/paperless-ngx#7125))
-   Chore: Ignores DRF 3.15.2 [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7122](paperless-ngx/paperless-ngx#7122))
-   Chore: show docker tag in UI for ci test builds [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7083](paperless-ngx/paperless-ngx#7083))

##### Dependencies

<details>
<summary>11 changes</summary>

-   Chore: Bulk backend updates [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7209](paperless-ngx/paperless-ngx#7209))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 14 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7200](paperless-ngx/paperless-ngx#7200))
-   Chore(deps): Bump certifi from 2024.6.2 to 2024.7.4 [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7166](paperless-ngx/paperless-ngx#7166))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 6 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7148](paperless-ngx/paperless-ngx#7148))
-   Chore(deps): Bump django-multiselectfield from 0.1.12 to 0.1.13 in the django group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7147](paperless-ngx/paperless-ngx#7147))
-   Chore(deps): Bump docker/build-push-action from 5 to 6 in the actions group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7125](paperless-ngx/paperless-ngx#7125))
-   Chore(deps): Bump the small-changes group across 1 directory with 4 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7128](paperless-ngx/paperless-ngx#7128))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 16 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7126](paperless-ngx/paperless-ngx#7126))
-   Chore(deps-dev): Bump ruff from 0.4.9 to 0.5.0 in the development group across 1 directory [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7120](paperless-ngx/paperless-ngx#7120))
-   Chore(deps-dev): Bump ws from 8.17.0 to 8.17.1 in /src-ui [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7114](paperless-ngx/paperless-ngx#7114))
-   Chore: update to Angular v18 [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7106](paperless-ngx/paperless-ngx#7106))

</details>

##### All App Changes

<details>
<summary>25 changes</summary>

-   Enhancement: disable add split button when approrpriate [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7215](paperless-ngx/paperless-ngx#7215))
-   Enhancement: wrapping of saved view fields d-n-d UI [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7216](paperless-ngx/paperless-ngx#7216))
-   Chore: Bulk backend updates [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7209](paperless-ngx/paperless-ngx#7209))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 14 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7200](paperless-ngx/paperless-ngx#7200))
-   Enhancement: support custom field icontains filter for select type [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7199](paperless-ngx/paperless-ngx#7199))
-   Chore: upgrade to DRF 3.15 [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7134](paperless-ngx/paperless-ngx#7134))
-   Feature: select custom field type [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7167](paperless-ngx/paperless-ngx#7167))
-   Feature: automatic sso redirect [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7168](paperless-ngx/paperless-ngx#7168))
-   Fix: include documents in trash for existing asn check [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7189](paperless-ngx/paperless-ngx#7189))
-   Chore: Initial conversion to pytest fixtures [@&#8203;stumpylog](https://github.com/stumpylog) ([#&#8203;7110](paperless-ngx/paperless-ngx#7110))
-   Enhancement: show more columns in mail frontend admin [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7158](paperless-ngx/paperless-ngx#7158))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 6 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7148](paperless-ngx/paperless-ngx#7148))
-   Chore(deps): Bump django-multiselectfield from 0.1.12 to 0.1.13 in the django group [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7147](paperless-ngx/paperless-ngx#7147))
-   Fix: include documents in trash in sanity check [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7133](paperless-ngx/paperless-ngx#7133))
-   Chore(deps): Bump the small-changes group across 1 directory with 4 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7128](paperless-ngx/paperless-ngx#7128))
-   Chore(deps): Bump the frontend-angular-dependencies group in /src-ui with 16 updates [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7126](paperless-ngx/paperless-ngx#7126))
-   Enhancement: use request user as owner of split / merge docs [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7112](paperless-ngx/paperless-ngx#7112))
-   Fix: handle errors for trash actions and only show documents user can restore or delete [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7119](paperless-ngx/paperless-ngx#7119))
-   Chore(deps-dev): Bump ruff from 0.4.9 to 0.5.0 in the development group across 1 directory [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7120](paperless-ngx/paperless-ngx#7120))
-   Chore(deps-dev): Bump ws from 8.17.0 to 8.17.1 in /src-ui [@&#8203;dependabot](https://github.com/dependabot) ([#&#8203;7114](paperless-ngx/paperless-ngx#7114))
-   Chore: update to Angular v18 [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7106](paperless-ngx/paperless-ngx#7106))
-   Enhancement: improve date parsing with accented characters [@&#8203;fdubuy](https://github.com/fdubuy) ([#&#8203;7100](paperless-ngx/paperless-ngx#7100))
-   Feature: improve history display of object names etc [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7102](paperless-ngx/paperless-ngx#7102))
-   Fix: dont include documents in trash in counts [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7111](paperless-ngx/paperless-ngx#7111))
-   Fix: use temp dir for split / merge [@&#8203;shamoon](https://github.com/shamoon) ([#&#8203;7105](paperless-ngx/paperless-ngx#7105))

</details>

</details>

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjYuNSIsInVwZGF0ZWRJblZlciI6IjM3LjQyOS4wIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIiwibGFiZWxzIjpbXX0=-->

Co-authored-by: Renovate Bot <bot@renovateapp.com>
Co-authored-by: Calvin Bui <3604363+calvinbui@users.noreply.github.com>
Reviewed-on: https://gitea.bui.services/calvinbui/ansible-monorepo/pulls/2723
Co-authored-by: renovate <renovate@noreply.gitea.bui.services>
Co-committed-by: renovate <renovate@noreply.gitea.bui.services>
Copy link
Contributor

github-actions bot commented Aug 9, 2024

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns. See our contributing guidelines for more details.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backend enhancement New feature non-trivial Requires approval by several team members
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants