Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added rate interval on provider #485

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

leobarcellos
Copy link
Contributor

This implements a rate interval when creating a Provider. Before the interval was fixed at 'second' rate and the slowest rate was 1 per second.

With this PR, it is possible to send campaigns on 1 per minute rate, 1 per hour, etc.

I've tested on 1 per minute and 1 per hour, both worked flawlessly.

image

Comment on lines 86 to 89
{ key: 'second', label: 'second' },
{ key: 'minute', label: 'minute' },
{ key: 'hour', label: 'hour' },
{ key: 'day', label: 'day' },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we modify these to use translation keys? Should already be in the corpus.

@leobarcellos leobarcellos requested a review from pushchris August 9, 2024 15:50
@pushchris pushchris merged commit b4bf9d5 into parcelvoy:main Aug 13, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants