feat: adds audience validation when validating a jwt #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctran88
force-pushed
the
PSG-4850-validate-aud-claims
branch
from
e56773f to
ad21f9b
Compare
ctran88
commented
Dec 5, 2024
custom/lib/Auth.php
Outdated
| throw new InvalidArgumentException('Missing kid in token'); | ||
| $decodedToken = JWT::decode($jwt, $this->jwks); | ||
|
|
||
| $aud = (array) $decodedToken->aud; |
There was a problem hiding this comment.
if not array, turn into array
Comment on lines
-55
to
-62
| $jwtSegments = explode('.', $jwt); | ||
| if (count($jwtSegments) !== 3) { | ||
| throw new InvalidArgumentException('Invalid JWT format'); | ||
| } |
There was a problem hiding this comment.
this is already checked by JWT::decode here
| if (!$header->kid) { | ||
| throw new InvalidArgumentException('Missing kid in token'); | ||
| if (!in_array($expectedAud, $aud)) { | ||
| throw new UnexpectedValueException('JWT audience does not match'); | ||
| } |
ctran88
force-pushed
the
PSG-5155-add-new-method-signatures
branch
from
ced84c7 to
87ce425
Compare
bertrmz
reviewed
Dec 10, 2024
custom/lib/Auth.php
Outdated
| $decodedToken = JWT::decode($jwt, $this->jwks); | ||
|
|
||
| $aud = (array) $decodedToken->aud; | ||
| $expectedAud = $this->app->getHosted() ? $this->appId : $this->app->getAuthOrigin(); |
There was a problem hiding this comment.
Similar to the note in passageidentity/passage-go#89 (comment), the app ID audience claim change is live for all apps in production, so this conditional can be simplified.
ctran88
force-pushed
the
PSG-4850-validate-aud-claims
branch
from
c0795cb to
f722ca7
Compare
tdeshong
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's New?
audclaim validation when validating a JWTScreenshots (if appropriate):
Type of change
Checklist:
Additional context