Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unselectable presets #1004

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Fix unselectable presets #1004

merged 3 commits into from
Dec 12, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Dec 12, 2024 •
edited
Loading

Revert #996 and do something midway:

  • When set, use preset filter as selection (disambiguate compatible presets)
  • Set initial preset filter with current selected server preset

Server selection still picks a random preset if:

  • Preset filter is "Any"
  • More than one preset is compatible

@keeshux keeshux self-assigned this Dec 12, 2024
@keeshux keeshux added the regression Used to work but doesn't anymore label Dec 12, 2024
@keeshux keeshux added this to the 3.0.0 / 6. Freeze milestone Dec 12, 2024
@keeshux keeshux merged commit 2075f10 into master Dec 12, 2024
1 check passed
@keeshux keeshux deleted the bugfix/unselectable-presets branch December 12, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@keeshux keeshux

Labels
regression Used to work but doesn't anymore
Projects
2024 Q1-Q4 Passepartout v3
Status: Done
Milestone
3.0.0 / 6. Freeze
Development

Successfully merging this pull request may close these issues.
1 participant
@keeshux