Reorganize Core Data containers #1017
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Only use beta receipt override on iOS - Hide unavailable code on tvOS
Backup repos use remote model.
keeshux
added a commit
that referenced
this pull request
Dec 20, 2024
The remote container is shared by ProfileManager and PreferencesManager, but it must be the same for CloudKit sync to work properly. Externalize the logic of onEligibleFeatures() so that the AppContext singleton can update the managers (and their repositories) with the new remote store. Now that the remote profile repository is reloaded every time that eligible features change, the .removeDuplicates() may also be restored. Just add a .dropFirst() to skip the initially empty value of eligible features. Even when features are eventually empty, a value is always emitted after IAPManager.reloadReceipt() Lastly, enable Core Data lightweight migration. Regressions from #1017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before anything, remove any code related to App Group containers from tvOS target because they are not available. Include the beta receipt override, it's broken for that reason.
In short:
urlForCaches).Then, rather than one container per model, merge models into:
Reuse the remote model for backups too.
This change is safe because: