Rewrite wrong refund logic #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was wrong all the time, according to Apple/Kvitto docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to Apple and Kvitto documentation, any receipt with a cancellation date should be discarded.
The app has always had this logic wrong, but it only revealed the issue after adding
cancelledPurchases.contains()to the feature eligibility condition:https://github.com/passepartoutvpn/passepartout-apple/blob/821d4c79f43c1bbad30d4611fba25c409dabebc9/PassepartoutLibrary/Sources/PassepartoutFrontend/Managers/ProductManager.swift#L222
So, if both a purchase and a refund of feature
.foobarexisted, whatever the dates, the purchase was incorrectly discarded.Fixes #459, fixes #461