Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace active modules count with a description #915

Merged
merged 8 commits into from
Nov 22, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 22, 2024

To get access to modules, try to avoid full Profile objects. Instead, replace the coupled ProfileHeader occurrences with a new intermediary ProfilePreview everywhere.

This way, a ProfileProcessor can inject the localized modules descriptions from above with the preview() method.

@keeshux keeshux self-assigned this Nov 22, 2024
@keeshux keeshux added enhancement New feature or request refactoring Improves software architecture labels Nov 22, 2024
@keeshux keeshux added this to the 3.0.0 / 7. Release milestone Nov 22, 2024
@keeshux keeshux merged commit 4b4fca8 into master Nov 22, 2024
1 check passed
@keeshux keeshux deleted the feature/localized-modules branch November 22, 2024 11:52
keeshux added a commit that referenced this pull request Nov 22, 2024
- Align to .leading in multi-line
- Wrap profile rows into top/bottom spacers to adjust to tallest cell in
grid

See #915
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring Improves software architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant