Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TV settings screen #943

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Improve TV settings screen #943

merged 3 commits into from
Nov 26, 2024

Conversation

keeshux
Copy link
Member

@keeshux keeshux commented Nov 26, 2024

  • Show detail side by side rather than navigate
  • Fix scrolling in purchased view

@keeshux keeshux added bug Something isn't working tvOS Related to tvOS app labels Nov 26, 2024
@keeshux keeshux self-assigned this Nov 26, 2024
@keeshux keeshux added this to the 3.0.0 / 6. Polish milestone Nov 26, 2024
@keeshux keeshux merged commit 80d40c3 into master Nov 26, 2024
1 check passed
@keeshux keeshux deleted the bugfix/tv-ui branch November 26, 2024 14:55
keeshux added a commit that referenced this pull request Nov 26, 2024
Broken by missing conditional in .scrollableOnTV() from #943
@keeshux keeshux mentioned this pull request Nov 26, 2024
keeshux added a commit that referenced this pull request Nov 26, 2024
- Text appearance on iOS/macOS (broken by #943)
- Visual ambiguity in "Purchased" when no feature is eligible
- "Purchased" must be a form on macOS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working tvOS Related to tvOS app
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant