Gw signatures #101
Merged
Gw signatures #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ready for review? Or was there more work needed? |
dbrakenhoff
reviewed
Oct 17, 2023
pastastore/store.py
Outdated
|
|
||
| Returns | ||
| ------- | ||
| sign : pandas.DataFrame |
There was a problem hiding this comment.
sign as a name is a bit confusing, but thats just a minor comment. Most people won't see or be bothered by that.
There was a problem hiding this comment.
renamed it to signatures_df
dbrakenhoff
approved these changes
Oct 17, 2023
|
I am not to sure what happens in the pastas 'dev' branch but I guess it is an error in one of the groundwater signatures functions. There is an open PR in pastas to solve this (pastas/pastas#636) so I think we can merge this |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.