Half compatibility with typeguard v4. #273
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anyone is feeling intrepid enough to take on the many many issues for compatibility between typeguard v4 and jaxtyping, then this might be a useful starting point.
typeguard v4 does some pretty magical things in that it reparses your source code in order to add its own typechecking. Unfortunately this doesn't play well with how jaxtyping generates functions, with the appropriate signatures, as the place typechecking is applied.
So whilst this PR solves some issues, there are many test failures still present.
Ah, if only we were working in a properly-typed compiled language!