Merge pull request #78 from patrickhener/fix-file-handle

Fixing issue #77, closing the file handle correctly

httpserver/server.go

@@ -8,6 +8,7 @@ import (
 	"net"
 	"net/http"
 	"os"
+	"runtime"
 	"time"
 
 	"github.com/gorilla/mux"
@@ -24,7 +25,11 @@ func (fs *FileServer) SetupMux(mux *mux.Router, what string) string {
 	var addr string
 	switch what {
 	case modeWeb:
-		mux.Methods(http.MethodPost).HandlerFunc(fs.upload)
+		mux.Methods(http.MethodPost).HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+			fs.upload(w, r)
+			// Run garbage collector to make sure file handle is synced and close properly
+			runtime.GC()
+		})
 		mux.PathPrefix("/").HandlerFunc(fs.handler)
 
 		addr = fmt.Sprintf("%+v:%+v", fs.IP, fs.Port)

httpserver/updown.go

@@ -77,6 +77,9 @@ func (fs *FileServer) upload(w http.ResponseWriter, req *http.Request) {
 			logger.Warnf("Error opening file: %+v", err)
 		}
 		defer func() {
+			if err := osFile.Sync(); err != nil {
+				logger.Errorf("error syncing file: %+v", err)
+			}
 			if err := osFile.Close(); err != nil {
 				logger.Errorf("error closing file: %+v", err)
 			}