-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): tabs aria ssr compat #2863
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e403f49 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Commitlint tests passed!More Info{
"valid": true,
"errors": [],
"warnings": [],
"input": "fix(core): tabs aria ssr compat"
} |
bennypowers
added a commit
to RedHat-UX/red-hat-design-system
that referenced
this pull request
Oct 9, 2024
✅ Deploy Preview for patternfly-elements ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Reviewed with Steven |
bennypowers
added a commit
to RedHat-UX/red-hat-design-system
that referenced
this pull request
Oct 9, 2024
* docs: reduce number of file watchers * docs: reimplement lit-ssr plugin enable ssr for uxdot-pattern * docs: implement ssr-able uxdot-pattern * docs: migrate uxdot-pattern usage to ssr * docs: fix pattern styles * docs: headings slotted into pattern * docs: watch for pattern files * docs: resizable demo container * chore: core patch * chore: remove extra file * docs: uxdot-pattern review comments * docs(tabs): patterns * docs: uxdot-pattern is not a provider Rather, it's color-palette attribute forwards to the internal rh-surface * docs: uxdot-pattern hydrate ssr state on client * docs: uxdot pattern responsive padding * docs: uxdot-pattern attrs * docs: pattern usage * feat: make generic ssr controller * chore: update pfe-core patch see patternfly/patternfly-elements#2863 * chore: update deps * style: whitespace * chore: update deps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did