Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI and semantic release for v6 branch #50

Merged
merged 6 commits into from
Nov 8, 2023

Conversation

jenny-s51
Copy link
Contributor

Closes #49

@jenny-s51 jenny-s51 linked an issue Oct 30, 2023 that may be closed by this pull request
@wise-king-sullyman
Copy link
Contributor

Do you know what's going on with the tests here? Looks like you've updated them a few times but they're still failing?

Copy link
Contributor Author

@jenny-s51 jenny-s51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wise-king-sullyman it looks like the tests are failing because ExpandableSection is setting some props to randomly generated values. Investigating to see how we can avoid these errors...

@wise-king-sullyman wise-king-sullyman merged commit 994c416 into patternfly:v6 Nov 8, 2023
5 checks passed
Copy link

🎉 This PR is included in version 6.0.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CI and semantic-release for the v6 branch
2 participants