-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update v6 alphas #54
update v6 alphas #54
Conversation
That class doesn't come from core - there are no |
They must come directly from |
@kmcfaul Can you do post the Patternfly document to surge and include it in this PR so design can see the updates. |
Here is the surge - https://windy-clocks-47747.surge.sh/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, the console is behaving the same way in your preview that it does on patternfly.org right now.
I know react-console has some styles which are defined and live in @patternfly/react-styles, so we should open a follow up issue for this PR to make sure those are all using the tokens correctly (and then an additional follow up here to consume the latest react-styles version).
But i don't see anything here IMO that would block this from merging as an alpha :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 This PR is included in version 6.0.0-prerelease.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #46.
pf-v6-c-console__xterm
doesn't seem to exist, did we have a v5 for this or was it always just a placeholder? @mcoker)