refactor(logger): capture all output #674
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
When running with low verbosity, any output that requires higher verbosity is completely thrown out, making it impossible to trace after the fact or replay later. This is particularly apparent when running tasks and using
bufferSubLogger
.Solution:
We could capture all output from loggers without also writing it out to the output stream (stderr). This would enable future work to replay it if specific information is found in the output after completion.
bufferSubLogger
instead oflogger.hasError
/logger.hasWarning
/etc.