Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(logger): capture all output #674

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paularmstrong
Copy link
Owner

@paularmstrong paularmstrong commented Mar 28, 2024

Problem:

When running with low verbosity, any output that requires higher verbosity is completely thrown out, making it impossible to trace after the fact or replay later. This is particularly apparent when running tasks and using bufferSubLogger.

Solution:

We could capture all output from loggers without also writing it out to the output stream (stderr). This would enable future work to replay it if specific information is found in the output after completion.

  • When capturing, include the log type/level in the captured stream
  • Use the above for determining whether it should be replayed from bufferSubLogger instead of logger.hasError/logger.hasWarning/etc.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for onerepo canceled.

Name Link
🔨 Latest commit 30176f3
🔍 Latest deploy log https://app.netlify.com/sites/onerepo/deploys/660586f3dd7adb0008e3d6ab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant