Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/100 46 rounded box view border corner #108

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Fix/100 46 rounded box view border corner #108

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0e501da
Merge pull request #76 from paulpatarinski/develop
paulpatarinski Jan 3, 2016
309cf6d
Merge pull request #77 from paulpatarinski/develop
paulpatarinski Jan 4, 2016
eab230f
Merge pull request #78 from paulpatarinski/develop
paulpatarinski Jan 4, 2016
40e7fe2
Fixes #100 and #46 in RoundedBoxView
oddbear Sep 23, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...iew/RoundedBoxView/RoundedBoxView.Forms.Plugin.Android/ExtensionMethods/ViewExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public static void UpdateBorder(this View nativeControl, Color color, int thickn

if (backgroundGradient != null)
{
var relativeBorderThickness = thickness*3;
var relativeBorderThickness = (int)System.Math.Round(Xamarin.Forms.Forms.Context.ToPixels(thickness)); //#46
backgroundGradient.SetStroke(relativeBorderThickness, color.ToAndroid());
}
}
Expand All @@ -75,7 +75,7 @@ public static void UpdateCornerRadius(this View nativeControl, double cornerRadi

if (backgroundGradient != null)
{
var relativeCornerRadius = (float) (cornerRadius*3.7);
var relativeCornerRadius = Xamarin.Forms.Forms.Context.ToPixels(cornerRadius); //#46
backgroundGradient.SetCornerRadius(relativeCornerRadius);
}
}
Expand Down
8 changes: 8 additions & 0 deletions ...oxView/RoundedBoxView/RoundedBoxView.Forms.Plugin.Android/RoundedBoxViewImplementation.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,13 @@ protected override void OnElementPropertyChanged(object sender, PropertyChangedE

this.UpdateFrom(_formControl, e.PropertyName);
}

public override void SetBackgroundColor(Android.Graphics.Color color)
{
//Fix for #100, will prevent background from getting overriden on BackgroundColor property changed by Forms.
//Alternative fix would be to check propertyname in OnElementPropertyChanged, and skip if it's BackgroundColor.
// if(e.PropertyName != nameof(VisualElement.BackgroundColor))
// base.OnElementPropertyChanged(sender, e);
}
}
}