Cleanup EL70x1 and EL70x7 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove "speed range" (default value already is 2000 steps/s) Remove "invert motor polarity" (default value already is 0) Remove "feedback type" (default value already is 1) Use ecmcEX70XX.cmd for EL7041-0052 and EL7041-1000 (also fixes a missing close parenthesis)
anderssandstrom
merged commit 5a6398e
into
paulscherrerinstitute:master
1 of 2 checks passed
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @kivel and @anderssandstrom,
Just a small cleanup. It started with a fix for the missing
)but then I noticed we are setting the default values on top of the reset. Not sure if you added that on purpose or not.Changes: