Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor datasetIngestor command further #103

Merged
merged 1 commit into from
Aug 23, 2024
Merged

refactor datasetIngestor command further #103

merged 1 commit into from
Aug 23, 2024

Conversation

consolethinks
Copy link
Collaborator

This refactor further improves code readability and maintainability:

  • better error handling
  • refactored error handling to avoid giant blocks of if-else statements
  • couple of logging improvements and bug fixes
  • streamlined the "nocopy" flag handling
  • a few other tidbits

sbliven
sbliven approved these changes Aug 23, 2024
View reviewed changes
Copy link
Member

@sbliven sbliven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a couple minor comments, but looks good overall.

cmd/commands/datasetIngestor.go Show resolved Hide resolved
cmd/commands/datasetIngestor.go Show resolved Hide resolved
cmd/commands/datasetIngestor.go Show resolved Hide resolved
cmd/commands/datasetIngestor.go Show resolved Hide resolved
@consolethinks consolethinks merged commit 0e1db34 into main Aug 23, 2024
3 checks passed
@consolethinks consolethinks deleted the refactor/ingestor_command branch August 23, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbliven sbliven sbliven approved these changes

@minottic minottic Awaiting requested review from minottic

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@consolethinks @sbliven