Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/v4backend #115
base: main
Are you sure you want to change the base?
Feature/v4backend #115
Changes from 1 commit
3c46560
f44116d
62389a4
1114b60
f7ca9db
d864d4c
9d8c99b
2dfb02c
7dfa34c
335a371
3831c94
4757845
fc006ee
c3b8c15
22c6991
919ea52
f2c0564
a5c70ba
5bbab98
3c832ee
bbd0f58
dcb57b2
48b81b5
ca8c254
adc4cb1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do I understand right that this, in addition to the filter here, checks if the ownerGroup is empty or it's equal to dataset.ownerGroup? If so, couldn't one achieve this by modifying the filter? Then (and also if not changing the filter), to find the missing datasets, one could transform datasetDetails into a map and loop over datasetList[i:end]. The ones which are not in the map are the ones missing. This will be O(n) (map creation) + O(m) (datasetList[i:end] loop), while the current implementation is O(~n (indexFunction) *m (loop)) (given the linear search, if I am not mistaken)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's also a good idea to add a test for this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I actually wanted to optimize it but I ended up just simplifying the original code. I'll try to apply your suggestion. (TODO)