Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test datasetIngestor/main.go prints help screen #15

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

kavir1698
Copy link
Collaborator

Was part of #1. After this and #14 are merged, #1 can be removed.

@kavir1698 kavir1698 requested a review from a team March 5, 2024 15:35
Copy link
Collaborator

@minottic minottic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please try to see if these function calls require an internet connection?

If so, could you please mock them? Otherwise we couple the tests of the CLI arguments with the resolution of the connection (I think these checks should have been called after the CLI arguments parsing when it was written, so they wouldn't be called if the instruction was to exist before)

@kavir1698
Copy link
Collaborator Author

could you please try to see if these function calls require an internet connection?

If so, could you please mock them? Otherwise we couple the tests of the CLI arguments with the resolution of the connection (I think these checks should have been called after the CLI arguments parsing when it was written, so they wouldn't be called if the instruction was to exist before)

Yes, the functions require internet access. They make an HTTP GET request to a specific URL. When there is no internet access, the HTTP GET request will fail. However, the functions handle this failure without crashing: it logs an error message and then returns. So no need to change them for this test

@minottic minottic self-requested a review March 21, 2024 10:52
@kavir1698 kavir1698 merged commit 15af396 into main Mar 21, 2024
2 checks passed
@kavir1698 kavir1698 deleted the datasetIngestor_main_test branch March 21, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants